Updated tests to use Helper #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/test_index_recovery --num_entries=18 --seed=0 --flip_list=index_parent_root --enable_crash crash root
…d incorrect usage of format/init devices
… to avoid boiler plate in tests code
hkadayam
force-pushed
the
test_index_crash_recovery
branch
from
7e579b5 to
c444a3a
Compare
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
hkadayam
commented
Jun 21, 2024
shosseinimotlagh
previously approved these changes
Jun 21, 2024
shosseinimotlagh
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the token to helper and made HSTestHelper from bunch of static methods to member methods. Originally its requirement is simple wrapper, but now its use has gone significantly, so it no longer make sense to be a static methods.
Made ReplTestHelper derived from HSTestHelper, so that restart homestore can be overridden by the consumer.