Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register log store callbacks after m_log_store is available #445

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

raakella1
Copy link
Contributor

@raakella1 raakella1 commented Jun 13, 2024

Wait until log store is created to register for the callbacks

@raakella1 raakella1 marked this pull request as draft June 13, 2024 21:44
@raakella1 raakella1 marked this pull request as ready for review June 13, 2024 22:40
@raakella1 raakella1 requested a review from xiaoxichen June 13, 2024 23:53
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is right!

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raakella1 raakella1 merged commit 718d169 into eBay:master Jun 14, 2024
22 checks passed
@raakella1 raakella1 deleted the durable_commit_regression branch June 14, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants