Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent chunk_size overflow. #382

Merged
merged 1 commit into from
Apr 17, 2024
Merged

prevent chunk_size overflow. #382

merged 1 commit into from
Apr 17, 2024

Conversation

xiaoxichen
Copy link
Collaborator

The default num_chunks is 1, if upper layer doesnt set num_chunk properly, the
chunk_size(uint32) = device_size(uint64) / num_chunks(uint32)

can be overlow.

The default num_chunks is 1, if upper layer doesnt set num_chunk
properly,  the
chunk_size(uint32) = device_size(uint64) / num_chunks(uint32)

can be overlow.

Signed-off-by: Xiaoxi Chen <[email protected]>
Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxichen xiaoxichen merged commit 6002488 into eBay:master Apr 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants