-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device manager load of chunks. #321
Conversation
7fb6f47
to
9d2020c
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 49.84% 58.42% +8.58%
==========================================
Files 134 107 -27
Lines 14337 9333 -5004
Branches 1730 1202 -528
==========================================
- Hits 7146 5453 -1693
+ Misses 6547 3350 -3197
+ Partials 644 530 -114 ☔ View full report in Codecov by Sentry. |
9d2020c
to
f1b04e9
Compare
dfc7a99
to
67c8422
Compare
67c8422
to
a2ab285
Compare
de87714
to
35b11dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a github issue for removing logdev_id from every log_group entry.
03cbe68
to
5e4e72d
Compare
b443c0e
to
ccc85e8
Compare
51cbf13
to
7bd7206
Compare
68c86d7
to
8226a76
Compare
please update conan ver |
Reviewed the files under devices directory and thy look good to me, expect some cosmetic comments. |
Chunks getting duplciate start offset while recovery. Add or cleanup logs for debugging. Add test case. Add more logdev for logstore test. Enable logstore test. Move rollback test to new logdev test.
Done. log_dev_test is using test_common::HSTestHelper::start_homestore |
Chunks getting duplciate start offset while recovery. Add or cleanup logs for debugging. Add test case.