Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log store ut #304

Closed
wants to merge 1 commit into from
Closed

Fix log store ut #304

wants to merge 1 commit into from

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Feb 6, 2024

Issue
The rollback was randomly failing because after truncation it expected no rollback records. But the test was writing to only one logstore. Because of other test cases in same file, other log store also have some log entries. Here truncate will truncate all logstores but device truncate will pick a logstore with the least idx and that value was smaller than the rollback records. This is because init was writing to only 1 store.

Fix.
Write to all logstores equally. Write rollback to one of the logstore(logstore 1). Truncate on all and should make all the logstores move forward together and delete those rollback records

@sanebay sanebay force-pushed the fix_log_store_ut branch 2 times, most recently from 6d95a06 to 22fed58 Compare February 6, 2024 22:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e073fe2) 47.65% compared to head (8f6e186) 58.60%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #304       +/-   ##
===========================================
+ Coverage   47.65%   58.60%   +10.95%     
===========================================
  Files         107      107               
  Lines        9271     9202       -69     
  Branches     1197     1174       -23     
===========================================
+ Hits         4418     5393      +975     
+ Misses       4390     3290     -1100     
- Partials      463      519       +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanebay sanebay requested review from hkadayam and yamingk February 6, 2024 22:49
@yamingk yamingk added this to the MileStone4.1 milestone Feb 7, 2024
@hkadayam hkadayam added bug Something isn't working Logstore labels Feb 7, 2024
@sanebay sanebay closed this Feb 14, 2024
@sanebay sanebay deleted the fix_log_store_ut branch February 14, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Logstore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants