Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The rollback was randomly failing because after truncation it expected no rollback records. But the test was writing to only one logstore. Because of other test cases in same file, other log store also have some log entries. Here truncate will truncate all logstores but device truncate will pick a logstore with the least idx and that value was smaller than the rollback records. This is because init was writing to only 1 store.
Fix.
Write to all logstores equally. Write rollback to one of the logstore(logstore 1). Truncate on all and should make all the logstores move forward together and delete those rollback records