Avoid flushing on wbcache non dirty buffers in merge case #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 62.60% 59.71% -2.89%
==========================================
Files 110 110
Lines 8990 9115 +125
Branches 1156 1173 +17
==========================================
- Hits 5628 5443 -185
- Misses 2829 3138 +309
- Partials 533 534 +1 ☔ View full report in Codecov by Sentry. |
In merge case, if merge not required and prep txn already called, parent wont be dirty adn we flush the cache causing invalid dirty buffer count. Concurrent thread iterators can't be reused.
shosseinimotlagh
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
[resource_mgr.cpp:39] ******************** Assertion failure: =====> Expected '-4096' to be >= to '0'
Fix
In merge case, even if merge is required, we call prepare txn and connect the left and parent. But during merge, we find merge is not required. The child node is modified but its next point to parent which is not modified or dirty. The child node is added to dirty list. Now during flushing, after child flush, it goes to next parent buffer and flushes that too even if its not dirty. This causes mismatch in m_hs_dirty_buf_cnt. Any buffer needs to flush should go through write_buf(). Its too complicated to unwind the prepare_txn in merge. Instead if the parent is not dirty ignore while flushing.
In merge case, if merge not required and prep txn already called, parent wont be dirty and we flush the cache causing invalid dirty buffer count. Concurrent insert vector iterators can't be reused.
./bin/test_index_btree --num_entries=500000
500k entries
[==========] 36 tests from 8 test suites ran. (11957416 ms total)
[ PASSED ] 36 tests