Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc stop for flip service in homestore. #280

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Jan 19, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (92b9dfe) 52.15% compared to head (4b9bb9c) 61.84%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/lib/device/virtual_dev.cpp 33.33% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   52.15%   61.84%   +9.69%     
==========================================
  Files         138      110      -28     
  Lines       13439     8725    -4714     
  Branches     1602     1121     -481     
==========================================
- Hits         7009     5396    -1613     
+ Misses       5962     2808    -3154     
- Partials      468      521      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanebay sanebay merged commit 7cb45a2 into eBay:master Jan 19, 2024
20 checks passed
@sanebay sanebay deleted the grpc_stop_rpc2 branch January 19, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants