disable copy construction for homestore superblock #246
Conversation
zichanglai
requested review from
hkadayam,
yamingk and
xiaoxichen
and removed request for
hkadayam and
yamingk
zichanglai
force-pushed
the
disable_superblock_copy_construction
branch
from
3d7e079 to
52e7f76
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 70.27% 70.35% +0.08%
==========================================
Files 97 97
Lines 7944 7952 +8
Branches 1017 1016 -1
==========================================
+ Hits 5583 5595 +12
+ Misses 1870 1869 -1
+ Partials 491 488 -3 ☔ View full report in Codecov by Sentry. |
|
Can you bump homstore patch version assuming it compiles successfully with homeobj? |
yes, I can bump homestore patch version for this. but homeobject need make little changes to build successfully because indextable interface is changed. |
zichanglai
force-pushed
the
disable_superblock_copy_construction
branch
from
52e7f76 to
2daa244
Compare
| rhs.m_meta_mgr_cookie = nullptr; | ||
| rhs.m_sb = nullptr; |
There was a problem hiding this comment.
why this two members is initialized in initialization list and set to nullptr here?
they are already initialized with nullptr
There was a problem hiding this comment.
this is move construction
| rhs.m_meta_mgr_cookie = nullptr; | ||
| rhs.m_sb = nullptr; |
with copy construction, superblock will be easy to cause duplicated metablk when call write() function if it is not carefully enough. we can avoid this by disable copy construction and only allow move construction.