issue: 226 Expose CP for external HomeStore client #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkadayam
reviewed
Nov 14, 2023
hkadayam
reviewed
Nov 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 70.07% 70.55% +0.48%
==========================================
Files 97 97
Lines 7932 7929 -3
Branches 1018 1019 +1
==========================================
+ Hits 5558 5594 +36
+ Misses 1881 1850 -31
+ Partials 493 485 -8 ☔ View full report in Codecov by Sentry. |
hkadayam
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed by HomeObject, Issue 109: eBay/HomeObject#109 to allow HomeObject to participant cp.
The testing is going to happen with HomeObject issue-109
Locally tested HomeObj build with private homestore package which passed the HOmeObj build test.