Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_freeable_nblks and get_defrag_nblks api to Vchunk #216

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

JacksonYao287
Copy link
Contributor

the two apis will be used by HeapChunkSelector to select a best candidate chunk for GC

the two apis will be used by HeapChunkSelector to select a best
candidate chunk for GC

Signed-off-by: Jie Yao <[email protected]>
@JacksonYao287 JacksonYao287 self-assigned this Oct 27, 2023
@JacksonYao287 JacksonYao287 requested a review from yamingk October 27, 2023 10:26
@JacksonYao287 JacksonYao287 added this to the MileStone3.10 milestone Oct 27, 2023
@JacksonYao287 JacksonYao287 requested a review from yamingk October 28, 2023 02:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (fcb47c0) 69.08% compared to head (389d77d) 69.21%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   69.08%   69.21%   +0.12%     
==========================================
  Files          93       93              
  Lines        7566     7575       +9     
  Branches      967      969       +2     
==========================================
+ Hits         5227     5243      +16     
+ Misses       1887     1884       -3     
+ Partials      452      448       -4     
Files Coverage Δ
src/lib/blkalloc/blk_allocator.h 94.11% <ø> (ø)
src/lib/blkalloc/varsize_blk_allocator.h 96.55% <ø> (ø)
src/lib/device/vchunk.cpp 0.00% <0.00%> (ø)
src/lib/blkalloc/fixed_blk_allocator.cpp 69.04% <0.00%> (-7.27%) ⬇️
src/lib/blkalloc/varsize_blk_allocator.cpp 73.20% <0.00%> (-0.79%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yamingk
Copy link
Contributor

yamingk commented Oct 28, 2023

LGTM.

@JacksonYao287 JacksonYao287 merged commit ddff069 into eBay:master Oct 29, 2023
16 checks passed
@JacksonYao287 JacksonYao287 deleted the add-get_defrag_nblks branch October 29, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants