fix solo repldev will be nullptr in map when homestore restart #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zichanglai
force-pushed
the
fix-solo-dev-nullptr-when-restart
branch
from
53a2285 to
c02c730
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 69.11% 69.19% +0.08%
==========================================
Files 93 93
Lines 7556 7558 +2
Branches 965 967 +2
==========================================
+ Hits 5222 5230 +8
- Misses 1868 1869 +1
+ Partials 466 459 -7
☔ View full report in Codecov by Sentry. |
hkadayam
reviewed
Oct 8, 2023
hkadayam
reviewed
Oct 8, 2023
| @@ -74,7 +73,7 @@ ReplicationServiceImpl::open_repl_dev(uuid_t group_id, std::unique_ptr< ReplDevL | |||
| auto it = m_rd_map.find(group_id); | |||
| if (it != m_rd_map.end()) { | |||
| // We already loaded the ReplDev, just call the group_id and attach the listener | |||
| auto& repl_dev = it->second; | |||
| auto repl_dev = it->second; | |||
There was a problem hiding this comment.
I am not clear how is this fixes the problem. At this time, someone already opened the repl_dev and group_id -> repl_dev has been mapped. So how is this storing by referencing or incrementing the ref_count of repl_dev solves this?
There was a problem hiding this comment.
but at Line80, this repl_dev will be moved, that is why I changed to make a copy of shared_ptr
zichanglai
force-pushed
the
fix-solo-dev-nullptr-when-restart
branch
from
c02c730 to
d172f35
Compare
zichanglai
force-pushed
the
fix-solo-dev-nullptr-when-restart
branch
from
d172f35 to
e5ffc33
Compare
xiaoxichen
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue when HS restarts, the Solo ReplDev in map will be set to nullptr. it is caused by an unexpected std::move() operation in src/lib/replication/service/repl_service_impl.cpp Line80