Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust num chunks requested in device manager. #197

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Oct 4, 2023

Disable index btree remove api's as its conflict with cp flush.
Fix timer related asan user after free issue while running UT's.

Copy link
Contributor

@hkadayam hkadayam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bd80010) 56.14% compared to head (cd31e11) 69.38%.
Report is 2 commits behind head on master.

❗ Current head cd31e11 differs from pull request most recent head 627079e. Consider uploading reports for the commit 627079e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #197       +/-   ##
===========================================
+ Coverage   56.14%   69.38%   +13.23%     
===========================================
  Files         108       93       -15     
  Lines        9676     7530     -2146     
  Branches     1199      960      -239     
===========================================
- Hits         5433     5225      -208     
+ Misses       3768     1851     -1917     
+ Partials      475      454       -21     
Files Coverage Δ
src/include/homestore/blkdata_service.hpp 100.00% <ø> (ø)
src/include/homestore/index_service.hpp 50.00% <ø> (+50.00%) ⬆️
src/include/homestore/logstore_service.hpp 100.00% <ø> (+66.66%) ⬆️
src/include/homestore/meta_service.hpp 100.00% <ø> (ø)
src/lib/blkdata_svc/blkdata_service.cpp 41.34% <ø> (ø)
src/lib/device/device_manager.cpp 76.74% <100.00%> (+0.44%) ⬆️
src/lib/device/physical_dev.cpp 80.34% <100.00%> (+1.61%) ⬆️
src/lib/homestore.cpp 86.74% <100.00%> (+13.45%) ⬆️
src/lib/index/index_service.cpp 83.33% <100.00%> (+83.33%) ⬆️
src/lib/logstore/log_store_service.cpp 71.68% <100.00%> (+8.75%) ⬆️
... and 1 more

... and 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix timer related asan issue.
Disable index btree remove api's as its conflict with cp flush.
@sanebay sanebay merged commit 119e67e into eBay:master Oct 5, 2023
16 checks passed
@sanebay sanebay deleted the device_fix branch October 5, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants