Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blkid's serialize api's. #196

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Sep 29, 2023

No description provided.

@sanebay sanebay requested a review from hkadayam September 29, 2023 22:51
@sanebay sanebay changed the title Fixes needed for homeobject to do put and get. Add blkid's serialize api's. Oct 2, 2023
hkadayam
hkadayam previously approved these changes Oct 3, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bd80010) 56.14% compared to head (8daf56a) 69.08%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #196       +/-   ##
===========================================
+ Coverage   56.14%   69.08%   +12.93%     
===========================================
  Files         108       93       -15     
  Lines        9676     7546     -2130     
  Branches     1199      966      -233     
===========================================
- Hits         5433     5213      -220     
+ Misses       3768     1872     -1896     
+ Partials      475      461       -14     
Files Coverage Δ
src/include/homestore/blk.h 71.73% <ø> (ø)
src/include/homestore/blkdata_service.hpp 100.00% <ø> (ø)
src/include/homestore/index_service.hpp 50.00% <ø> (+50.00%) ⬆️
src/include/homestore/logstore_service.hpp 100.00% <ø> (+66.66%) ⬆️
src/include/homestore/meta_service.hpp 100.00% <ø> (ø)
src/lib/blkdata_svc/blkdata_service.cpp 41.34% <ø> (ø)
src/lib/checkpoint/cp_mgr.cpp 77.77% <100.00%> (+12.51%) ⬆️
src/lib/common/resource_mgr.hpp 100.00% <ø> (ø)
src/lib/device/physical_dev.cpp 80.34% <100.00%> (+1.61%) ⬆️
src/lib/homestore.cpp 86.74% <100.00%> (+13.45%) ⬆️
... and 6 more

... and 62 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shosseinimotlagh shosseinimotlagh self-requested a review October 5, 2023 07:25
@sanebay sanebay merged commit cd4d671 into eBay:master Oct 5, 2023
@sanebay sanebay deleted the ho_fixes_needed branch October 5, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants