Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cp flush during shutdown in index btree #194

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Add cp flush during shutdown in index btree #194

merged 2 commits into from
Oct 5, 2023

Conversation

shosseinimotlagh
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (bd80010) 56.14% compared to head (7c68d2b) 69.17%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #194       +/-   ##
===========================================
+ Coverage   56.14%   69.17%   +13.02%     
===========================================
  Files         108       93       -15     
  Lines        9676     7550     -2126     
  Branches     1199      966      -233     
===========================================
- Hits         5433     5223      -210     
+ Misses       3768     1866     -1902     
+ Partials      475      461       -14     
Files Coverage Δ
src/include/homestore/index/index_internal.hpp 66.66% <ø> (+66.66%) ⬆️
src/include/homestore/index/index_table.hpp 90.65% <100.00%> (ø)
src/include/homestore/index_service.hpp 50.00% <ø> (+50.00%) ⬆️
src/lib/homestore.cpp 86.74% <100.00%> (+13.45%) ⬆️
src/lib/index/index_service.cpp 73.46% <46.15%> (+73.46%) ⬆️

... and 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanebay sanebay changed the title Fix cp flush in index btree Add cp flush during shutdown in index btree Oct 2, 2023
hkadayam
hkadayam previously approved these changes Oct 4, 2023
@shosseinimotlagh shosseinimotlagh merged commit bf8e6fd into eBay:master Oct 5, 2023
16 checks passed
@shosseinimotlagh shosseinimotlagh deleted the add_index_stop branch November 13, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the index btree cp flush tests for variable length key
4 participants