Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SoloReplDev - a pass through replication device #177

Merged
merged 11 commits into from
Sep 21, 2023
Merged

SoloReplDev - a pass through replication device #177

merged 11 commits into from
Sep 21, 2023

Conversation

hkadayam
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 18.22% and project coverage change: -1.20% ⚠️

Comparison is base (4b84609) 50.02% compared to head (74972ee) 48.82%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   50.02%   48.82%   -1.20%     
==========================================
  Files          86       93       +7     
  Lines        7307     7500     +193     
  Branches      956      973      +17     
==========================================
+ Hits         3655     3662       +7     
- Misses       3263     3445     +182     
- Partials      389      393       +4
Files Changed Coverage Δ
src/include/homestore/blkdata_service.hpp 100.00% <ø> (ø)
src/include/homestore/checkpoint/cp_mgr.hpp 66.66% <ø> (ø)
src/include/homestore/homestore_decl.hpp 63.63% <ø> (+9.46%) ⬆️
src/include/homestore/index_service.hpp 0.00% <ø> (-50.00%) ⬇️
src/include/homestore/replication/repl_decls.h 0.00% <0.00%> (ø)
src/include/homestore/replication/repl_dev.h 0.00% <0.00%> (ø)
src/include/homestore/replication_service.hpp 0.00% <ø> (ø)
src/lib/device/virtual_dev.hpp 88.23% <ø> (ø)
src/lib/meta/meta_blk_service.cpp 25.97% <0.00%> (ø)
src/lib/replication/repl_dev/solo_repl_dev.cpp 0.00% <0.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd szmyd self-requested a review September 19, 2023 22:49
@szmyd szmyd added this to the 2 milestone Sep 19, 2023
@hkadayam hkadayam linked an issue Sep 19, 2023 that may be closed by this pull request
First support for ReplDev and have SoloReplDevImpl #150
Closed
szmyd
szmyd previously approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hkadayam and others added 10 commits September 20, 2023 16:11
@hkadayam
MultiBlkId for all vdev and services to avoid caller to use std::vector
e42e016 
* All services exposes default std::vector< BlkId > for allocating and writing blocks. This open
ended structure has difficulty for upper layers to serialize. Hence introducing MultiBlkId
which has tigther structure so upper layers can serialize and use in-place of BlkId. Existing
BlkId can still be used and some services also provide backward compatibile std::vector< BlkId >

* Added the test for blkid
@hkadayam
MultiBlkId for all vdev and services to avoid caller to use std::vector
3dedf4f 
* All services exposes default std::vector< BlkId > for allocating and writing blocks. This open
ended structure has difficulty for upper layers to serialize. Hence introducing MultiBlkId
which has tigther structure so upper layers can serialize and use in-place of BlkId. Existing
BlkId can still be used and some services also provide backward compatibile std::vector< BlkId >

* Added the test for blkid
@hkadayam
Merge after rebasing
910ff8b
@hkadayam
Fix test failures after merging append_blk_allocator and other changes
00233f3
@hkadayam
Delete src/include/homestore/homestore_mod.hpp
183a27d
@hkadayam
Delete src/include/homestore/new_blk.h
cccefec
@hkadayam
Delete src/lib/homestore_mod.cpp
be531c6
@hkadayam
SoloReplDev - a pass through replication device
fb45c4e
@hkadayam
Merged with latest changes, fixed test_meta_blk_mgr memory leak
13fb835
@hkadayam
Merge the latest changes into solo_repl branch
7c8fb83
yamingk
yamingk previously approved these changes Sep 21, 2023
View reviewed changes
@hkadayam hkadayam dismissed stale reviews from yamingk and szmyd via 74972ee September 21, 2023 01:55
@hkadayam hkadayam merged commit 319a3d5 into master Sep 21, 2023
16 checks passed
@szmyd szmyd deleted the solo_repl branch October 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamingk yamingk yamingk approved these changes

@szmyd szmyd szmyd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MileStone2
Development

Successfully merging this pull request may close these issues.

First support for ReplDev and have SoloReplDevImpl
4 participants
@hkadayam @codecov-commenter @yamingk @szmyd