Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to the README. #175

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Some improvements to the README. #175

merged 5 commits into from
Sep 20, 2023

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Sep 19, 2023

Apparently this increases code coverage by 2.38% !!!! ;)

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Patch coverage: 51.08% and project coverage change: +2.38% 🎉

Comparison is base (b6c6a89) 47.56% compared to head (b3ae4f1) 49.95%.
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   47.56%   49.95%   +2.38%     
==========================================
  Files          86       86              
  Lines        7114     7313     +199     
  Branches      916      959      +43     
==========================================
+ Hits         3384     3653     +269     
+ Misses       3403     3270     -133     
- Partials      327      390      +63     
Files Changed Coverage Δ
...clude/homestore/btree/detail/btree_mutate_impl.ipp 55.38% <ø> (+2.29%) ⬆️
src/include/homestore/homestore_decl.hpp 54.16% <0.00%> (-7.74%) ⬇️
src/include/homestore/logstore_service.hpp 33.33% <ø> (ø)
src/include/homestore/meta_service.hpp 100.00% <ø> (ø)
src/lib/blkalloc/append_blk_allocator.h 100.00% <ø> (ø)
src/lib/blkdata_svc/blk_read_tracker.hpp 100.00% <ø> (ø)
src/lib/device/journal_vdev.hpp 57.14% <ø> (ø)
src/lib/device/physical_dev.hpp 83.78% <ø> (ø)
src/lib/device/vchunk.cpp 0.00% <0.00%> (ø)
src/lib/device/virtual_dev.hpp 88.23% <ø> (ø)
... and 26 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hkadayam
hkadayam previously approved these changes Sep 19, 2023
Copy link
Contributor

@hkadayam hkadayam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome :-)

@szmyd
Copy link
Collaborator Author

szmyd commented Sep 19, 2023

awesome :-)

I don't think I have the descriptions/analogies quite right. Better ideas?

@szmyd szmyd requested a review from yamingk September 20, 2023 04:17
@szmyd szmyd merged commit c504ddd into eBay:master Sep 20, 2023
16 checks passed
@szmyd szmyd deleted the readme_improv branch September 20, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants