-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Service Recovery and its test case. #164
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 54.10% 49.39% -4.71%
==========================================
Files 96 86 -10
Lines 8922 7108 -1814
Branches 1112 915 -197
==========================================
- Hits 4827 3511 -1316
+ Misses 3685 3260 -425
+ Partials 410 337 -73
☔ View full report in Codecov by Sentry. |
yamingk
changed the title
Add Data Service Recovery and its test case.
Data Service Recovery and its test case.
Sep 13, 2023
* make VChunk CopyAssignable and CopyConstructible * internalChunk -> m_internal_chunk
…or (#166) * All services exposes default std::vector< BlkId > for allocating and writing blocks. This open ended structure has difficulty for upper layers to serialize. Hence introducing MultiBlkId which has tigther structure so upper layers can serialize and use in-place of BlkId. Existing BlkId can still be used and some services also provide backward compatibile std::vector< BlkId >
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Data Service Recovery and its test case.
The recovery flow for data service is(most of the logic are already there):
A new test case added with alloc/write/free/cp_flush, then recover, followed by another round of alloc/write/cp.
Test case added and passed.