Disable buffered i/o; can lead to data loss.

eBay · Sep 26, 2024 · d769722 · d769722
1 parent ab9dd4e
commit d769722
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/conanfile.py b/conanfile.py
@@ -2,7 +2,7 @@
 
 class HomestoreConan(ConanFile):
     name = "homestore"
-    version = "3.7.2"
+    version = "3.7.3"
 
     homepage = "https://github.corp.ebay.com/SDS/homestore"
     description = "HomeStore"

diff --git a/src/engine/device/physical_dev.cpp b/src/engine/device/physical_dev.cpp
@@ -198,8 +198,7 @@ PhysicalDev::PhysicalDev(DeviceManager* const mgr, const std::string& devname, c
     m_info_blk.first_chunk_id = INVALID_CHUNK_ID;
 
     int oflags_used{oflags};
-    if (devname.find("/tmp") == 0 ||
-        (m_drive_iface->interface_type() == drive_interface_type::uring && m_mgr->is_hdd_direct_io_mode() == false)) {
+    if (devname.find("/tmp") == 0 || (m_mgr->is_hdd(devname) && m_mgr->is_hdd_direct_io_mode() == false)) {
         // tmp directory in general does not allow Direct I/O
         LOGINFO("Trying to remove O_DIRECT bit from open flags: before: {}, after: {}", oflags_used,
                 oflags & (~O_DIRECT));