Fix asan stack use after return error.

conanfile.py

@@ -5,7 +5,7 @@
 
 class HomestoreConan(ConanFile):
     name = "homestore"
-    version = "5.1.14"
+    version = "5.1.15"
 
     homepage = "https://github.com/eBay/Homestore"
     description = "HomeStore Storage Engine"

src/lib/checkpoint/cp_mgr.cpp

@@ -291,7 +291,7 @@ void CPManager::start_cp_thread() {
 
     {
         std::unique_lock< std::mutex > lk{ctx->mtx};
-        ctx->cv.wait(lk, [&ctx] { return (ctx->thread_cnt == 1); });
+        ctx->cv.wait(lk, [ctx] { return (ctx->thread_cnt == 1); });
     }
 }
 

src/lib/index/wb_cache.cpp

@@ -57,7 +57,7 @@ void IndexWBCache::start_flush_threads() {
 
     for (int32_t i{0}; i < nthreads; ++i) {
         iomanager.create_reactor("index_cp_flush" + std::to_string(i), iomgr::INTERRUPT_LOOP, 1u,
-                                 [this, &ctx](bool is_started) {
+                                 [this, ctx](bool is_started) {
                                      if (is_started) {
                                          {
                                              std::unique_lock< std::mutex > lk{ctx->mtx};
@@ -71,7 +71,7 @@ void IndexWBCache::start_flush_threads() {
 
     {
         std::unique_lock< std::mutex > lk{ctx->mtx};
-        ctx->cv.wait(lk, [&ctx, nthreads] { return (ctx->thread_cnt == nthreads); });
+        ctx->cv.wait(lk, [ctx, nthreads] { return (ctx->thread_cnt == nthreads); });
     }
 }
 

src/lib/logstore/log_store.cpp

@@ -73,7 +73,7 @@ bool HomeLogStore::write_sync(logstore_seq_num_t seq_num, const sisl::io_blob& b
 
     {
         std::unique_lock< std::mutex > lk{ctx->write_mutex};
-        ctx->write_cv.wait(lk, [&ctx] { return ctx->write_done; });
+        ctx->write_cv.wait(lk, [ctx] { return ctx->write_done; });
     }
 
     return ctx->ret;

src/lib/logstore/log_store_service.cpp

@@ -260,7 +260,7 @@ void LogStoreService::start_threads() {
 
     m_flush_fiber = nullptr;
     iomanager.create_reactor("log_flush_thread", iomgr::TIGHT_LOOP | iomgr::ADAPTIVE_LOOP, 1 /* num_fibers */,
-                             [this, &ctx](bool is_started) {
+                             [this, ctx](bool is_started) {
                                  if (is_started) {
                                      m_flush_fiber = iomanager.iofiber_self();
                                      {
@@ -273,7 +273,7 @@ void LogStoreService::start_threads() {
 
     m_truncate_fiber = nullptr;
     iomanager.create_reactor("logstore_truncater", iomgr::INTERRUPT_LOOP, 2 /* num_fibers */,
-                             [this, &ctx](bool is_started) {
+                             [this, ctx](bool is_started) {
                                  if (is_started) {
                                      m_truncate_fiber = iomanager.sync_io_capable_fibers()[0];
                                      {
@@ -285,7 +285,7 @@ void LogStoreService::start_threads() {
                              });
     {
         std::unique_lock< std::mutex > lk{ctx->mtx};
-        ctx->cv.wait(lk, [&ctx] { return (ctx->thread_cnt == 2); });
+        ctx->cv.wait(lk, [ctx] { return (ctx->thread_cnt == 2); });
     }
 }
 

src/lib/replication/repl_dev/raft_repl_dev.cpp

@@ -218,7 +218,7 @@ void RaftReplDev::on_fetch_data_received(intrusive< sisl::GenericRpcData >& rpc_
             // accumulate the sgs for later use (send back to the requester));
             sgs_vec.push_back(sgs);
 
-            async_read(local_blkid, sgs, total_size).thenValue([this, &ctx](auto&& err) {
+            async_read(local_blkid, sgs, total_size).thenValue([this, ctx](auto&& err) {
                 if (err) {
                     COUNTER_INCREMENT(m_metrics, read_err_cnt, 1);
                     RD_REL_ASSERT(false, "Error in reading data"); // TODO: Find a way to return error to the Listener
@@ -236,7 +236,7 @@ void RaftReplDev::on_fetch_data_received(intrusive< sisl::GenericRpcData >& rpc_
     {
         // wait for read to complete;
         std::unique_lock< std::mutex > lk{ctx->mtx};
-        ctx->cv.wait(lk, [&ctx] { return (ctx->outstanding_read_cnt == 0); });
+        ctx->cv.wait(lk, [ctx] { return (ctx->outstanding_read_cnt == 0); });
     }
 
     // now prepare the io_blob_list to response back to requester;