Add seal shard api #81
Conversation
sanebay
requested review from
hkadayam,
szmyd,
zichanglai,
xiaoxichen and
yamingk
and removed request for
szmyd
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 81.31% 83.90% +2.58%
==========================================
Files 31 31
Lines 1204 1261 +57
Branches 99 100 +1
==========================================
+ Hits 979 1058 +79
+ Misses 173 154 -19
+ Partials 52 49 -3
☔ View full report in Codecov by Sentry. |
|
lgtm，it will be more clear once put/get blob pr is merged and rebase on that. |
Add test to seal shard with recovery.
sanebay
force-pushed
the
ho_shard_seal
branch
from
358918d to
b688a69
Compare
Rebased to latest. Please review. |
| value.iovs.push_back(iovec(buf_ptr, msg_size)); | ||
|
|
||
| // replicate this seal shard message to PG members; | ||
| repl_dev->async_alloc_write(header, sisl::blob{}, value, req); |
There was a problem hiding this comment.
We also need to update the shard's metablk from active to sealed state, right?
There was a problem hiding this comment.
It was already there in hs_shard_manager.cpp on commit
sanebay
force-pushed
the
ho_shard_seal
branch
from
dcac87a to
e7b5c4b
Compare
Similar to create shard.
Add test to create shard, seal and put blob and restart and verify shard is still sealed and put blob fails.