Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File based implementation without Replication. #76

Closed
wants to merge 24 commits into from
Closed

File based implementation without Replication. #76

wants to merge 24 commits into from

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Sep 29, 2023

I have added recovery; we can replace the memory component if we agree this is more useful while still maintaining a de-coupled "alt".

@szmyd szmyd requested review from yamingk and xiaoxichen September 29, 2023 04:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (c251a37) 70.68% compared to head (882335c) 67.05%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   70.68%   67.05%   -3.64%     
==========================================
  Files          28       33       +5     
  Lines         689      865     +176     
  Branches       54       63       +9     
==========================================
+ Hits          487      580      +93     
- Misses        169      248      +79     
- Partials       33       37       +4     
Files Coverage Δ
src/lib/file_backend/file_homeobject.hpp 100.00% <100.00%> (ø)
src/lib/file_backend/file_pg_manager.cpp 88.88% <88.88%> (ø)
src/lib/file_backend/file_shard_manager.cpp 79.59% <79.59%> (ø)
src/lib/file_backend/file_blob_manager.cpp 70.45% <70.45%> (ø)
src/lib/file_backend/file_homeobject.cpp 19.17% <19.17%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd szmyd marked this pull request as draft September 29, 2023 05:12
@szmyd szmyd marked this pull request as ready for review September 29, 2023 18:10
@szmyd szmyd requested a review from hkadayam September 29, 2023 18:12
@szmyd szmyd marked this pull request as draft October 20, 2023 17:21
@szmyd szmyd closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants