Make logging module consistent and remove atomic. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmyd
force-pushed
the
consolidate_logging
branch
from
a830d2f to
8b434ad
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 70.59% 70.68% +0.08%
==========================================
Files 28 28
Lines 687 689 +2
Branches 54 54
==========================================
+ Hits 485 487 +2
Misses 169 169
Partials 33 33
☔ View full report in Codecov by Sentry. |
szmyd
commented
Sep 29, 2023
| @@ -22,7 +22,7 @@ void HeapChunkSelector::add_chunk(csharedChunk& chunk) { m_chunks.emplace(VChunk | |||
| void HeapChunkSelector::add_chunk_internal(const chunk_num_t chunkID) { | |||
| if (m_chunks.find(chunkID) == m_chunks.end()) { | |||
| // sanity check | |||
| LOGWARN("No chunk found for ChunkID {}", chunkID); | |||
| LOGWARNMOD(homeobject, "No chunk found for ChunkID {}", chunkID); | |||
There was a problem hiding this comment.
HeapChunkSelector currently does not include homeobject headers...so this is left alone,
szmyd
changed the title
szmyd
commented
Sep 29, 2023
| @@ -16,7 +16,6 @@ AlignConsecutiveDeclarations: false | |||
| AlignEscapedNewlines: Right | |||
| AlignOperands: false | |||
| AlignTrailingComments: true | |||
| AllowShortBlocksOnASingleLine: true | |||
There was a problem hiding this comment.
This was a dupe; it's below as well.
szmyd
force-pushed
the
consolidate_logging
branch
2 times, most recently
from
d29f928 to
64965b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.