Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlobRoute : Comparison and Hash can be made much cheaper without string formatting. #66

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Sep 21, 2023

@sanebay we can reuse this class and derive from BtreeKey in HomeStore (or that's the goal).

src/lib/memory/homeobject.hpp Outdated Show resolved Hide resolved
@szmyd szmyd changed the title Comparison and Hash can be made much cheaper without string formatting. BlobRoute : Comparison and Hash can be made much cheaper without string formatting. Sep 21, 2023
@szmyd szmyd force-pushed the make_blobroute_cheaper branch from 61c228f to 24e5e84 Compare September 21, 2023 04:35
@szmyd
Copy link
Collaborator Author

szmyd commented Sep 21, 2023

Example logs:

[blob_manager.cpp:17:_put_blob] Writing Blob 0001:000000000001:00000000000020a4
[blob_manager.cpp:39:_get_blob] Looking up Blob 0001:000000000000:00000000000007fb
[blob_manager.cpp:39:_get_blob] Looking up Blob 0001:000000000001:0000000000000842
[blob_manager.cpp:42:_get_blob] Blob [0001:000000000000:00000000000007fb] missing during get
[blob_manager.cpp:42:_get_blob] Blob [0001:000000000000:000000000000083a] missing during get
[blob_manager.cpp:39:_get_blob] Looking up Blob 0001:000000000000:0000000000000000
[blob_manager.cpp:61:_del_blob] Tombstoning Blob 0001:000000000000:000000000000083c
[blob_manager.cpp:39:_get_blob] Looking up Blob 0001:000000000001:0000000000000805
[blob_manager.cpp:68:_del_blob] Blob [0001:000000000000:0000000000000835] missing during del
[blob_manager.cpp:61:_del_blob] Tombstoning Blob 0001:000000000000:0000000000000838

@szmyd szmyd force-pushed the make_blobroute_cheaper branch from bf764ca to f967a07 Compare September 21, 2023 05:32
src/lib/blob_route.hpp Outdated Show resolved Hide resolved
xiaoxichen
xiaoxichen previously approved these changes Sep 21, 2023
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 53.84% and project coverage change: -1.18% ⚠️

Comparison is base (741478f) 82.23% compared to head (50f2b90) 81.05%.
Report is 1 commits behind head on main.

❗ Current head 50f2b90 differs from pull request most recent head f5acdb8. Consider uploading reports for the commit f5acdb8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   82.23%   81.05%   -1.18%     
==========================================
  Files          18       19       +1     
  Lines         456      454       -2     
  Branches       44       44              
==========================================
- Hits          375      368       -7     
- Misses         53       58       +5     
  Partials       28       28              
Files Changed Coverage Δ
src/lib/blob_route.hpp 28.57% <28.57%> (ø)
src/lib/homestore/shard_manager.cpp 83.92% <50.00%> (-0.19%) ⬇️
src/lib/homeobject_impl.hpp 100.00% <100.00%> (ø)
src/lib/memory/homeobject.hpp 100.00% <100.00%> (ø)
src/lib/memory/shard_manager.cpp 81.81% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd szmyd merged commit b5cc370 into eBay:main Sep 21, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants