-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlobRoute : Comparison and Hash can be made much cheaper without string formatting. #66
Conversation
61c228f
to
24e5e84
Compare
Example logs:
|
bf764ca
to
f967a07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 82.23% 81.05% -1.18%
==========================================
Files 18 19 +1
Lines 456 454 -2
Branches 44 44
==========================================
- Hits 375 368 -7
- Misses 53 58 +5
Partials 28 28
☔ View full report in Codecov by Sentry. |
@sanebay we can reuse this class and derive from BtreeKey in HomeStore (or that's the goal).