Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short circuit sealing a sealed shard. Test as well. #60

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Sep 18, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -1.00% ⚠️

Comparison is base (951d61d) 82.04% compared to head (80e21a5) 81.04%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   82.04%   81.04%   -1.00%     
==========================================
  Files          16       16              
  Lines         245      248       +3     
  Branches       25       26       +1     
==========================================
  Hits          201      201              
- Misses         28       31       +3     
  Partials       16       16              
Files Changed Coverage Δ
src/lib/memory/shard_manager.cpp 80.00% <0.00%> (ø)
src/lib/shard_manager.cpp 87.09% <80.00%> (-2.19%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zichanglai zichanglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szmyd szmyd merged commit 291b070 into eBay:main Sep 19, 2023
24 checks passed
@szmyd szmyd deleted the short_circuit_seal branch September 19, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants