Movable io_blob_safe does not require wrapping. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 81.78% 82.04% +0.25%
==========================================
Files 16 16
Lines 247 245 -2
Branches 25 25
==========================================
- Hits 202 201 -1
+ Misses 29 28 -1
Partials 16 16
☔ View full report in Codecov by Sentry. |
xiaoxichen
approved these changes
Sep 16, 2023
| @@ -31,4 +31,10 @@ BlobManager::NullAsyncResult HomeObjectImpl::del(shard_id shard, blob_id const& | |||
| }); | |||
| } | |||
|
|
|||
| Blob Blob::clone() const { | |||
| auto new_body = sisl::io_blob_safe(body.size); | |||
| std::memcpy(new_body.bytes, body.bytes, body.size); | |||
There was a problem hiding this comment.
can we add deep copy into the copy assignment of io_blob_safe?
are we on purpose delete that to avoid unconscious deep-copy?
There was a problem hiding this comment.
You mean move the memcpy down? Yeah; we can talk to hari about that; it'd be a sisl change; but still a clone() operation i think for the reason you point out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.