Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename snapshot_data to snapshot_obj #238

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Rename snapshot_data to snapshot_obj #238

merged 1 commit into from
Dec 4, 2024

Conversation

yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Dec 4, 2024

Update snapshot function name based on the homestore API change.

@yuwmao yuwmao requested a review from xiaoxichen December 4, 2024 06:52
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.15%. Comparing base (1746bcc) to head (bb0b2b4).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   63.15%   65.15%   +1.99%     
==========================================
  Files          32       32              
  Lines        1900     1980      +80     
  Branches      204      213       +9     
==========================================
+ Hits         1200     1290      +90     
+ Misses        600      582      -18     
- Partials      100      108       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoxichen xiaoxichen merged commit 24655f4 into eBay:main Dec 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants