Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current leader if error is NOT_LEADER #237

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Besroy
Copy link
Contributor

@Besroy Besroy commented Dec 3, 2024

No description provided.

@Besroy Besroy changed the title add current leader is error is NOT_LEADER add current leader if error is NOT_LEADER Dec 3, 2024
@Besroy Besroy force-pushed the add_cur_leader_in_errmsg branch from ed00fdd to 333fdfc Compare December 3, 2024 09:57
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (1746bcc) to head (333fdfc).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_blob_manager.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   63.15%   65.20%   +2.04%     
==========================================
  Files          32       32              
  Lines        1900     1980      +80     
  Branches      204      213       +9     
==========================================
+ Hits         1200     1291      +91     
+ Misses        600      581      -19     
- Partials      100      108       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Besroy Besroy merged commit 5398f92 into eBay:main Dec 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants