Update baseline_resync branch with latest commits #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement fix pg size
this PR aims to support spare replicas in raft test framework , which is essential for testing pg move. what`s more, a basic replace_member UT is added
…hunk_id field to shard_info_superblk. 2. Enhance defensive checks in ChunkSelector for input validation and exception handling. 3. Adapt unit tests and introduce PGExceedSpaceTest.
1. Add check to ensure max_it points to an available chunk. If not, it indicates there are no available chunks left. 2. Add safeguards in the create and recover pg paths to ensure the pg size cannot be zero.
1 change on_destroy signature to adapt to homestore 2 add is leader check before any raft write operation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## baseline_resync #234 +/- ##
==================================================
Coverage ? 65.64%
==================================================
Files ? 33
Lines ? 2262
Branches ? 255
==================================================
Hits ? 1485
Misses ? 653
Partials ? 124 ☔ View full report in Codecov by Sentry. |
|
I think you can rebase and force push @yuwmao |
|
We also need to make some changes to PGBlobIterator, I left some TODO in the PGBlobIterator. |
koujl
force-pushed
the
baseline_resync
branch
from
5070584 to
5e09bc8
Compare
Bug Fixes: - Resolved issues in create_shard and seal_shard functions to ensure correct shard management. Enhancements: - Added validation to prevent creation of placement groups with sizes smaller than the chunk size. Test Improvements: - pg test: - Added tests to verify that creating a placement group with a size smaller than the chunk size results in failure. - shard test: - Created shard but shard size is larger than pg space left which should be failed. - Verified that successfully created shards have identical virtual chunk layouts.
|
This PR simply merged the latest commits into the feature branch. Let's leave further changes / bug fixes to the next PR for simplicity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.