Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create_snapshot #233

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix create_snapshot #233

merged 1 commit into from
Nov 29, 2024

Conversation

Besroy
Copy link
Contributor

@Besroy Besroy commented Nov 28, 2024

m_snapshot_context is nullptr in the first create_snapshot, add check to avoid crash.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.09%. Comparing base (1746bcc) to head (d4751e3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   63.15%   64.09%   +0.93%     
==========================================
  Files          32       32              
  Lines        1900     1972      +72     
  Branches      204      210       +6     
==========================================
+ Hits         1200     1264      +64     
- Misses        600      603       +3     
- Partials      100      105       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxichen xiaoxichen merged commit 93ae09c into eBay:main Nov 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants