Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UT for PGBlobIterator #228

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Nov 19, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (baseline_resync@303a0a0). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             baseline_resync     #228   +/-   ##
==================================================
  Coverage                   ?   60.14%           
==================================================
  Files                      ?       33           
  Lines                      ?     2040           
  Branches                   ?      232           
==================================================
  Hits                       ?     1227           
  Misses                     ?      709           
  Partials                   ?      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuwmao yuwmao changed the title Add UT for PGBlobIterator Add UT for PGBlobIterator[Drafting] Nov 19, 2024
@yuwmao yuwmao force-pushed the baseline_resync branch 2 times, most recently from abfe028 to a454abe Compare November 20, 2024 03:51
@yuwmao yuwmao changed the title Add UT for PGBlobIterator[Drafting] Add UT for PGBlobIterator Nov 20, 2024
koujl
koujl previously approved these changes Nov 22, 2024
src/lib/homestore_backend/tests/hs_blob_tests.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/tests/hs_blob_tests.cpp Outdated Show resolved Hide resolved
JacksonYao287
JacksonYao287 previously approved these changes Nov 24, 2024
Copy link
Collaborator

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls also update conan file version

@yuwmao yuwmao dismissed stale reviews from JacksonYao287 and koujl via 2c260ea November 26, 2024 03:43
@yuwmao
Copy link
Contributor Author

yuwmao commented Nov 26, 2024

LGTM, pls also update conan file version

Updated, thx!

xiaoxichen
xiaoxichen previously approved these changes Nov 26, 2024
@xiaoxichen
Copy link
Collaborator

good to see the comprehensive UT find some bugs :)

@yuwmao yuwmao merged commit 8344019 into eBay:baseline_resync Nov 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants