support spare replicas in raft test framework #226
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 63.15% 65.20% +2.04%
==========================================
Files 32 32
Lines 1900 1911 +11
Branches 204 204
==========================================
+ Hits 1200 1246 +46
+ Misses 600 561 -39
- Partials 100 104 +4 ☔ View full report in Codecov by Sentry. |
JacksonYao287
force-pushed
the
support-spare-replicas
branch
from
074ec37 to
f520c3a
Compare
JacksonYao287
force-pushed
the
support-spare-replicas
branch
from
f520c3a to
8ffa9a8
Compare
| if (in_member_id == g_helper->my_replica_id()) { | ||
| while (!am_i_in_pg(pg_id)) { | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(1000)); | ||
| LOGINFO("new member is waiting to become a member of pg {}", pg_id); | ||
| } | ||
|
|
||
| wait_for_all(pg_shard_id_vec[pg_id].back() /*the last shard id in this pg*/, |
There was a problem hiding this comment.
as discussed, this doesnt guarantee to be right once baseline resync is on , it doesnt sync follow the LSN order.
There was a problem hiding this comment.
yes, but for now, we can not do this , since if a member is not leader , it can not get its own commit lsn
see
will implement a new wait_for_all as soon as we can get commit_lsn at follower
cc @sanebay
There was a problem hiding this comment.
OK, it makes sense to add self lsn to repl_service_ctx::get_raft_status().... When I implement this function I didnt realize we have this requirement./
this PR aims to support spare replicas in raft test framework , which is essential for testing pg move. what`s more, a basic replace_member UT is added