-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flatbuffer for baseline resync #170
Conversation
yamingk
commented
Apr 19, 2024
- define flatbuffer structure for pg/shard creation during base line resync
- define blob data flatbuffer structure during blob data resync
- add a mock api to pick up homestore 6.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
shard_id : uint64; // shard id to be created with; | ||
shard_size : uint64; // shard size; | ||
created_time : uint64; // shard creation time | ||
last_modified_time : uint64; // shard last modify time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we agree to add created_lsn on shard, do we want to sync this ?
or actually setting the created_lsn to snapshot_lsn is also right, just sort of inconsistency
we need to aware when we doing the scrubber.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be no harm adding that, let me add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
native_include "sisl/utility/non_null_ptr.hpp";
this is needed on both .fbs files to compile with c++.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 68.69% 70.24% +1.55%
==========================================
Files 30 30
Lines 1581 1536 -45
Branches 163 160 -3
==========================================
- Hits 1086 1079 -7
+ Misses 408 369 -39
- Partials 87 88 +1 ☔ View full report in Codecov by Sentry. |