Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatbuffer for baseline resync #170

Merged
merged 13 commits into from
Aug 29, 2024
Merged

flatbuffer for baseline resync #170

merged 13 commits into from
Aug 29, 2024

Conversation

yamingk
Copy link
Contributor

@yamingk yamingk commented Apr 19, 2024

  1. define flatbuffer structure for pg/shard creation during base line resync
  2. define blob data flatbuffer structure during blob data resync
  3. add a mock api to pick up homestore 6.3

@yamingk yamingk requested review from xiaoxichen and sanebay April 19, 2024 00:49
xiaoxichen
xiaoxichen previously approved these changes Apr 25, 2024
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sanebay
sanebay previously approved these changes Apr 30, 2024
@yamingk yamingk dismissed stale reviews from sanebay and xiaoxichen via 58a8b6e August 20, 2024 20:47
sanebay
sanebay previously approved these changes Aug 20, 2024
shard_id : uint64; // shard id to be created with;
shard_size : uint64; // shard size;
created_time : uint64; // shard creation time
last_modified_time : uint64; // shard last modify time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we agree to add created_lsn on shard, do we want to sync this ?
or actually setting the created_lsn to snapshot_lsn is also right, just sort of inconsistency we need to aware when we doing the scrubber.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be no harm adding that, let me add it.

Copy link
Contributor

@sanebay sanebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

native_include "sisl/utility/non_null_ptr.hpp";
this is needed on both .fbs files to compile with c++.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.24%. Comparing base (acb04e8) to head (255e3a5).
Report is 12 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   68.69%   70.24%   +1.55%     
==========================================
  Files          30       30              
  Lines        1581     1536      -45     
  Branches      163      160       -3     
==========================================
- Hits         1086     1079       -7     
+ Misses        408      369      -39     
- Partials       87       88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yamingk yamingk merged commit 4d999d4 into eBay:main Aug 29, 2024
25 checks passed
@yamingk yamingk deleted the yk_resync_fb branch August 29, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatbuff def for Baseline resync Baseline Resync: FlatBuf definition
4 participants