SealShard state change in pre-commit #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonYao287
force-pushed
the
precommit
branch
from
08f639f to
67d9c61
Compare
zichanglai
reviewed
Dec 4, 2023
JacksonYao287
force-pushed
the
precommit
branch
2 times, most recently
from
bbceb31 to
4dc0358
Compare
JacksonYao287
force-pushed
the
precommit
branch
from
82525d5 to
63679a7
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 69.53% 68.01% -1.53%
==========================================
Files 30 30
Lines 1474 1538 +64
Branches 148 157 +9
==========================================
+ Hits 1025 1046 +21
- Misses 369 409 +40
- Partials 80 83 +3 ☔ View full report in Codecov by Sentry. |
zichanglai
reviewed
Dec 8, 2023
JacksonYao287
force-pushed
the
precommit
branch
3 times, most recently
from
efacc25 to
69380a0
Compare
JacksonYao287
force-pushed
the
precommit
branch
from
69380a0 to
f3a4ed9
Compare
JacksonYao287
force-pushed
the
precommit
branch
2 times, most recently
from
fb90397 to
f57ffb7
Compare
JacksonYao287
force-pushed
the
precommit
branch
from
914b477 to
67c74bb
Compare
JacksonYao287
force-pushed
the
precommit
branch
from
e80cb57 to
14a21f2
Compare
xiaoxichen
approved these changes
Apr 5, 2024
| // move seal_shard to pre_commit can not fundamentally solve the conflict between seal_shard and put_blob, since | ||
| // put_blob handler will only check the shard state at the very beginning and will not check again before proposing to | ||
| // raft, so we need a callback to check whether we can handle this request before appending log, which is previous to | ||
| // pre_commit. |
There was a problem hiding this comment.
prior to the pre_commit of put_blob
There was a problem hiding this comment.
thanks for pointing out this misusing , will be careful!
| // raft, so we need a callback to check whether we can handle this request before appending log, which is previous to | ||
| // pre_commit. | ||
|
|
||
| // FIXME after we have the callback, which is coming in homestore. |
There was a problem hiding this comment.
an issue in HS and HO respectively, pls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR, we change the shard state from open to sealed when pre_committing the seal_shard message, and change the state back to open if roll_back happens.
but this can not fundamentally solve the conflict between seal_shard and put_blob, since when handling put_blob request, it will only check the shard state at the very beginning, and will not check again before entering raft phase(propose_to_raft). so we need a callback before appending the log where we could check the shard state again.
this should be done in homestore to provide the interfact accepting this callback
for some corner case , like we have a stale blob for shard-1 in shard-2, it will behandled by GC.