Adaptive changes for homestore/6.6.x (#246)

* Avoid returning nullptr for cp_swtichover. HS will assume the consumer not participanting CP if nullptr returned. Signed-off-by: Xiaoxi Chen <[email protected]> * Handle ReplServiceError::DATA_DUPLICATED --------- Signed-off-by: Xiaoxi Chen <[email protected]> Co-authored-by: Xiaoxi Chen <[email protected]>
eBay · Dec 24, 2024 · 067612f · 067612f
1 parent b9d3fbf
commit 067612f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/conanfile.py b/conanfile.py
@@ -9,7 +9,7 @@
 
 class HomeObjectConan(ConanFile):
     name = "homeobject"
-    version = "2.1.18"
+    version = "2.1.19"
 
     homepage = "https://github.com/eBay/HomeObject"
     description = "Blob Store built on HomeReplication"

diff --git a/src/lib/homestore_backend/hs_cp_callbacks.cpp b/src/lib/homestore_backend/hs_cp_callbacks.cpp
@@ -23,7 +23,9 @@ using homestore::CPContext;
 
 namespace homeobject {
 
-std::unique_ptr< CPContext > HSHomeObject::MyCPCallbacks::on_switchover_cp(CP* cur_cp, CP* new_cp) { return nullptr; }
+std::unique_ptr< CPContext > HSHomeObject::MyCPCallbacks::on_switchover_cp(CP* cur_cp, CP* new_cp) {
+    return std::make_unique< CPContext >(new_cp);
+}
 
 // when cp_flush is called, it means that all the dirty candidates are already in the dirty list.
 // new dirty candidates will arrive on next cp's context.

diff --git a/src/lib/homestore_backend/hs_pg_manager.cpp b/src/lib/homestore_backend/hs_pg_manager.cpp
@@ -46,10 +46,13 @@ PGError toPgError(ReplServiceError const& e) {
     case ReplServiceError::OK:
         DEBUG_ASSERT(false, "Should not process OK!");
         [[fallthrough]];
+    case ReplServiceError::DATA_DUPLICATED:
+        [[fallthrough]];
     case ReplServiceError::FAILED:
         return PGError::UNKNOWN;
+    default:
+        return PGError::UNKNOWN;
     }
-    return PGError::UNKNOWN;
 }
 
 [[maybe_unused]] static homestore::ReplDev& pg_repl_dev(PG const& pg) {