Dispatch a click event on an off-DOM <a> element when clicking on .table-seamless-links rows
#2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `.table-seamless-links` rows This brings the interaction closer to clicking on an actual `a` tag and enables Ctrl-Click again. Having an `a` in there is still not feasible, because we cannot have any elements between `tr` and `td`.
richardebeling
approved these changes
Dec 7, 2024
janno42
reviewed
Dec 9, 2024
There was a problem hiding this comment.
This solves the main problem, but it's not very nice. After control-clicking, there's an ugly selection box around part of the row, and because we don't have an anchor element, there's no link preview in the browser.
Maybe we should use a grid like on the results page instead of tables?
|
With this version, the outline is fixed, but I think we can't show a link preview with this approach at all. I think replacing the table with grid is the end solution, but I don't know when someone will do this and it will definitely take longer than the fix here |
janno42
approved these changes
Dec 9, 2024
evap/evaluation/templates/base.html
Outdated
| window.location.assign(row.dataset.url); | ||
| row.addEventListener("click", event => { | ||
| // We navigate via the <a> tag to enable browser behavior for Ctrl-Click. We cannot insert an actual | ||
| // <a> tag, because there cannot be any non-table tags between the for example <tbody> and <tr>. |
There was a problem hiding this comment.
Suggested change
| // <a> tag, because there cannot be any non-table tags between the for example <tbody> and <tr>. | |
| // <a> tag, because there cannot be any non-table tags between for example <tbody> and <tr>. |
Kakadus
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2292
This brings the interaction closer to clicking on an actual
atag and enables Ctrl-Click again. Having anain there is still not feasible, because we cannot have any elements betweentrandtd.