Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint #2285

Merged
merged 25 commits into from
Dec 9, 2024
Merged

Add eslint #2285

merged 25 commits into from
Dec 9, 2024

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented Sep 23, 2024 •
edited
Loading

Enables just recommended configs from eslint, strict typecheck and stylistic configs from tseslint.

This will not run in ci because it would just fail. Intended for local checks and Codacy: Codacy should pick this up and only check the diff

@Kakadus Kakadus marked this pull request as draft September 30, 2024 15:27
richardebeling
richardebeling requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed: If we provide a config, it should run and pass in CI

@Kakadus Kakadus changed the title Add eslit tseslint config Add eslint tseslint config Sep 30, 2024
@Kakadus Kakadus force-pushed the add-eslit-tseslint-config branch 4 times, most recently from cd19832 to aaf9c56 Compare October 28, 2024 18:42
@Kakadus Kakadus force-pushed the add-eslit-tseslint-config branch 4 times, most recently from 2b052be to c2c4f52 Compare November 18, 2024 17:47
@Kakadus Kakadus marked this pull request as ready for review November 25, 2024 18:36
@Kakadus Kakadus force-pushed the add-eslit-tseslint-config branch from c2c4f52 to 8f1b469 Compare November 25, 2024 18:56
niklasmohrin
niklasmohrin approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

evap/static/ts/eslint.config.js Outdated Show resolved Hide resolved
Kakadus added 12 commits December 2, 2024 17:31
@Kakadus
add eslint tseslint and configure it so that it passes with warnings
fcd83e4
@Kakadus
Prefer the safe : unknown for a catch callback variable
617f0b8
@Kakadus
The two values in this comparison do not have a shared enum type
04a96ea
@Kakadus
autofix: Array type using 'Array<HTMLElement>' is forbidden. Use 'HTM…
79a4332 
…LElement[]' instead
@Kakadus
use HTMLElement type in querySelector
b2ff33e
@Kakadus
autofix: Unnecessary 'else' after 'return'
14fa5c0
@Kakadus
Prefer using an optional chain expression instead, as it's more conci…
c519aee 
…se and easier to read
@Kakadus
autofix: Unnecessary optional chain on a non-nullish value
5b4a56c
@Kakadus
autofix: use const instead
2fdee14
@Kakadus
autofix: Type string trivially inferred from a string literal, remove…
057c05e 
… type annotation
@Kakadus
autofix+format: This assertion is unnecessary since it does not chang…
3339bff 
…e the type of the expression
@Kakadus
autofix: The generic type arguments should be specified as part of th…
843db52 
…e constructor type arguments
@Kakadus Kakadus force-pushed the add-eslit-tseslint-config branch from 8f1b469 to 6a759d8 Compare December 2, 2024 16:31
@Kakadus
Copy link
Collaborator Author

Kakadus commented Dec 2, 2024

(just rebased without code changes)

niklasmohrin
niklasmohrin approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@Kakadus Kakadus changed the title Add eslint tseslint config Add eslint Dec 9, 2024
@Kakadus Kakadus merged commit 9e753d0 into e-valuation:main Dec 9, 2024
11 of 12 checks passed
@Kakadus Kakadus deleted the add-eslit-tseslint-config branch December 9, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kakadus @richardebeling @niklasmohrin