Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix django stubs 5.0.0 #2186

Merged
merged 4 commits into from
May 13, 2024
Merged

Fix django stubs 5.0.0 #2186

merged 4 commits into from
May 13, 2024

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented May 13, 2024

This would require us to add django-stubs-ext as a runtime requirement, in order to define an itemgetter for these generic classes via monkeypatch

The new annotations do not improve much actually, because Form.fields is de-facto untyped (typeddjango/django-stubs#1514)

dependabot bot and others added 2 commits May 6, 2024 19:45
Bumps [django-stubs](https://github.com/typeddjango/django-stubs) from 4.2.6 to 5.0.0.
- [Release notes](https://github.com/typeddjango/django-stubs/releases)
- [Commits](typeddjango/django-stubs@4.2.6...5.0.0)

---
updated-dependencies:
- dependency-name: django-stubs
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@Kakadus Kakadus force-pushed the fix-django-5.0.0 branch from 0801c84 to b63c3bb Compare May 13, 2024 16:22
@Kakadus Kakadus force-pushed the fix-django-5.0.0 branch from b63c3bb to eeef9d0 Compare May 13, 2024 17:52
@Kakadus Kakadus force-pushed the fix-django-5.0.0 branch from eeef9d0 to c91e504 Compare May 13, 2024 17:57
@Kakadus Kakadus requested a review from richardebeling May 13, 2024 18:01
@Kakadus Kakadus linked an issue May 13, 2024 that may be closed by this pull request
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@Kakadus Kakadus merged commit 3c8524f into e-valuation:main May 13, 2024
10 checks passed
@Kakadus Kakadus deleted the fix-django-5.0.0 branch May 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update Django Stubs on new release
2 participants