Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcut for toggling flag state of textanswer #1973

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add keyboard shortcut for toggling flag state of textanswer #1973

merged 1 commit into from
Jul 10, 2023

Conversation

niklasmohrin
Copy link
Member

@niklasmohrin niklasmohrin commented Jul 3, 2023 •
edited
Loading

Closes #1974

@niklasmohrin
Copy link
Member Author

Any opinion on clicking on input vs label? Users click on the label, but clicking the input should be just as fine, unless we ever move the input under another clickable thing, but that would be insane. Not impossible though. Any more thoughts?

@richardebeling
Copy link
Member

Any opinion on clicking on input vs label? Users click on the label, but clicking the input should be just as fine, unless we ever move the input under another clickable thing, but that would be insane. Not impossible though. Any more thoughts?

I'm fine with both, I think both are equally likely to break. If we want to prevent that, we'd need to add a test.

@niklasmohrin
Copy link
Member Author

Pinging #1854

janno42
janno42 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

@niklasmohrin niklasmohrin merged commit 56d79d0 into e-valuation:main Jul 10, 2023
@niklasmohrin niklasmohrin deleted the flag-it branch July 10, 2023 17:53
@niklasmohrin niklasmohrin restored the flag-it branch September 18, 2023 15:48
@niklasmohrin niklasmohrin deleted the flag-it branch September 18, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 janno42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hotkey for flagging Textanswers
3 participants
@niklasmohrin @richardebeling @janno42