Update pylint-django to 2.5.3 (pytlin 3 compatible), disable noisy rules

e-valuation · Oct 22, 2023 · fa4da5e · fa4da5e
1 parent 208c99e
commit fa4da5e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -64,7 +64,9 @@ disable = [
     "too-many-arguments",             # we can't determine a good limit here. reviews should spot bad cases of this.
     "duplicate-code",                 # Mostly imports and test setup.
     "cyclic-import",                  # We use these inside methods that require models from multiple apps. Tests will catch actual errors.
-    "unsupported-binary-operation",   # broken in pylint 2.15: https://github.com/PyCQA/pylint/issues/7381
+    "unsupported-binary-operation",   # broken in pylint: https://github.com/PyCQA/pylint/issues/7381
+    "use-implicit-booleaness-not-comparison-to-string",  # forces us to use less expressive code
+    "use-implicit-booleaness-not-comparison-to-zero",    # forces us to use less expressive code
 ]
 
 ##############################################

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -9,7 +9,7 @@ isort~=5.12.0
 model-bakery~=1.16.0
 mypy~=1.6.0
 openpyxl-stubs~=0.1.25
-pylint-django~=2.5.3
+pylint-django~=2.5.4
 pylint~=3.0.1
 tblib~=2.0.0
 xlrd~=2.0.1