-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(climate-tool): Forecast page placeholder #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khalifan-kfan
From what I can see it's looking in a good state (will just need to hook up the live data when available and do some minor tidying), although I noticed this PR also has the partial changes from the resources share PR which still needs a bit of work.
So either it would be better to wait until after that is merged, or cherry-pick the relevant commits for the forecasts feature and put them on a clean branch and open a new pr.
Let me know what approach you would like to take and I can help assist
Ohh sorry about that, let me first attempt the cherry-picking and see if it could help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khalifan-kfan
All looks good now, thanks for tidying up the commits.
I've added one small commit 3c10a17 to refactor some *ngIf
to @if(...)
syntax and replace the module with standalone component just because I'm slowly trying to migrate more of the code base to use the modern syntax. I've also fixed an issue where the slide-in animation wasn't showing (basically the parent div needs to always be available with a .active
class selector and child content contain the if condition instead)
I've also removed the placeholder forecast for now until we get the feature fully integrated with the climate api, but happy to merge as-is and then add a new issue to complete the feature when ready.
Description
This pull request adds the page for climate forecast in the climate tool.
Discussion
closes #277
Preview
Screenshots / Videos
Please check the route
localhost:4200/climate/forecast
to test.on click (dummy pdf)