feat(resources): client-side search

[Pamella014]

Description

created a new feature for searching through available resources

Feed Discussion

Requesting for feedback on the search results UI

closes #206

Screenshots / Videos

Updated 2024-01-30

PICSA.1.webm

---

Original

[chrismclarke]

nit(non-blocking)
If code isn't required it is better to delete rather than comment out. If there is really good reason to keep (e.g. you know for sure it will be required in near-future) then that should be included in a comment - but usually you can still just delete and if needed in the future recover.

[chrismclarke]

Thanks for the PR

Apologies review is a bit rushed, I haven't tested the feature locally yet, but please see a few inline comments that I think would be good to address first and then we can move onto a more in-depth review after

[chrismclarke]

Thanks for the PR

Apologies review is a bit rushed, I haven't tested the feature locally yet, but please see a few inline comments that I think would be good to address first and then we can move onto a more in-depth review after

[Pamella014]

Good afternoon @chrismclarke . I have pushed new changes including the requested fixes, let me know if you have any feedback when you review them. I was also need clarification on whether to make the search results clickable and if yes what should be returned when clicked.

[chrismclarke]

Thanks @Pamella014 for making all the changes. Can confirm all is working as expected on my side.

For the question of what search results should link to, that turned out to be a more difficult question because we have 3 different types of resources that all behave differently (links, collections and files).

To try and simplify things I've made the search results divide by the 3 types, and then was able to reuse the existing components to handle display. Most these changes added in 3aa005, see video below for demo

PICSA.1.webm

I think this is now good to go, there's a few minor changes which I think would be nice to have, but I'll communicate these in a follow-up

[Pamella014]

Thanks for demo @chrismclarke , looks great