Fix seasonal calender #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalifan-kfan
added
enhancement
There was a problem hiding this comment.
Thanks @khalifan-kfan
I can see the route changes and have tested as working well (nice work!)
I can also see the form validation which looks a lot nicer
I think that covers all the main changes and looks good to me, but let me know if there's anything else you think I should be aware of. Also next time if possible please include a few more bullet points/screenshots in the description as it makes it easier for the reviewer and also for our automated release notes
chrismclarke
approved these changes
Nov 23, 2023
chrismclarke
added
the
Tool: Seasonal Calendar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feedback on seasonal calendar implementation.
Discussion
Fixing non-blocking tasks from the previous pull request
Preview
Screenshots / Videos
Include at least 1-2 screenshots of videos if visual changes