Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/option tool autosave #122

Merged
merged 6 commits into from
Apr 15, 2023
Merged

Feat/option tool autosave #122

merged 6 commits into from
Apr 15, 2023

Conversation

khalifan-kfan
Copy link
Collaborator

Description

This allows the user to save midway through the process of filling the stepper. This comes in handy if the user doesn't want to finish the process but saves what they have so far filled in the stepper.
Also, this PR refactors the logic of the buttons just slightly.
Not sure if "autosave" is the right word to describe this PR though. :-|

Discussion

This feature follows the discussion from the option tool tasks checklist
[#106]
Next will be the integration of translation

Preview

https://picsa.app

Screenshots / Videos

image
If a user tries to save without giving at least the name
image

Copy link
Collaborator

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khalifan-kfan
I tested the functionality and working well, nice work.

I've made a few edits to add functionality to delete a saved entry from the practice page, and made a few of the buttons more consistent with the budget tool. It seems my code editor made a lot of additional edits, likely due to the prettier plugin I have installed (e.g. swapping double quotes for single), so the changes look much bigger than they are.

I'll try organise a follow-up PR to enforce consistent code styling automatically so there aren't such big diffs when I try to make edits, but for now I'd say all this is looking good and moving onto translations sounds like a solid idea

@chrismclarke chrismclarke merged commit 016ef66 into main Apr 15, 2023
@chrismclarke chrismclarke deleted the feat/option-tool-autosave branch April 15, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants