Ft Crop-information-tool #121
Conversation
…crop-information-tool
FaithDaka
added
Feedback Discussion
and removed
help wanted
There was a problem hiding this comment.
Really nice work! Very impressed to see all the the different cell merging working, I imagine it must have been quite tricky to work out
I was also able to get your filter working (77829b6), which is really nice to have also, so I think to start with this is all good to go. I'll update the checklist for potential next tasks, but for now thanks for the addition!
| <th colspan="4" rowspan="4">Crop Information Sheet – CHIPATA MET STATION </th> | ||
| </tr> | ||
| <tr ngClass="right-cells fixed-width"> | ||
| <th>1-Nov</th> |
There was a problem hiding this comment.
nit(non-blocking)
Likely at some point these headings will also come from the data definition, but fine to hardcode for now
| templateUrl: './crop-probability-table-header.component.html', | ||
| styleUrls: ['./crop-probability-table-header.component.scss'], | ||
| }) | ||
| export class CropProbabilityTableHeaderComponent {} |
There was a problem hiding this comment.
nice idea to split this into it's own component, definitely helps keep the rest of the code a lot tidier
| <mat-form-field> | ||
| <mat-label>Filter</mat-label> | ||
| <input | ||
| matInput |
There was a problem hiding this comment.
I can see this is the implementation you had issues with. Taking a quick look your code is good, I think there's just a minor issue because the matInput you've referenced hasn't been imported into the material module
(super annoying I know, so many separate imports and the error message it not even remotely useful - I only realised by chance)
I'll add a commit to include
| variety: 'SC 637', | ||
| days: '130-136', | ||
| water: ['512-535mm'], | ||
| probabilities: ['10/10', '10/10', '8-9/10', '3-5/10', '0-1/10'], |
There was a problem hiding this comment.
Really nice having such a comprehensive example, thanks for adding all of this
Description
Discussion
The table filter is currently commented due to display bugs. When the filter is active, the probability table doesn't show and the CSS is distorted.
Feedback discussion points if relevant (should also tag as
Feedback Discussion)Tracked in #89
Screenshots / Videos