Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate option tool with extension toolkit #120

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

chrismclarke
Copy link
Collaborator

@chrismclarke chrismclarke commented Apr 12, 2023

Description

Main Changes

  • Add support for accessing the option tool directly from within the extension app
  • Add picsa header to main component

Additional Changes

  • Routing added for future support of additional pages
  • Components refactored into standalone module
  • Material module moved into components folder
  • Icon registration moved to the corresponding material module

Review Notes

The main things to test:

  • Running the options tool standalone still works as expected (e.g. yarn nx serve picsa-tools-option-tool or using nx extension on vscode)
  • Running the main app via yarn start works to display the option tool content at /option

Discussion

@khalifan-kfan
The process of integrating one app in another is a little bit complicated, so I don't expect you to follow all the changes in this PR. But a few things to be aware of:

  • If running the extension app you will still need to manually navigate to /option, in the future we will link from the home page
  • The code to add custom icons has been moved into the local tool .\components\material.module.ts file
  • When you add further components in the future you will want to import them into the local .\components\components.module.ts, instead of the main app.module (better support for lazy-loading)

Tracked in #106

Preview

Live preview available at
https://picsa-extension-toolkit--pr120-feat-options-tool-in-iberpk1j.web.app/option

Screenshots / Videos

Option tool now appears on /option when running the extension app via yarn start
The tool also inherits theming from the main app, such as country colour
image

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Visit the preview URL for this PR (updated for commit 66da35d):

https://picsa-extension-toolkit--pr120-feat-options-tool-in-iberpk1j.web.app

(expires Wed, 19 Apr 2023 20:03:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2435c4a5f2b9750fe5c819a7a14bcf9433816983

Copy link
Collaborator

@khalifan-kfan khalifan-kfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrismclarke Thanks for this, it looks alright.
You'll have to take me through some part of how you set up routing any time your available

@chrismclarke chrismclarke merged commit 33d5fe6 into main Apr 13, 2023
@chrismclarke chrismclarke deleted the feat/options-tool-integration branch April 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants