Add some icons to mat stepper #118
Conversation
There was a problem hiding this comment.
Thanks for adding @khalifan-kfan - I like how you've used a bunch of the existing mat-icons where possible and nice idea to try and add custom img tags to include our own svgs.
As mentioned on slack it would be good to refactor the img tags to be custom mat-icons instead, as that way we can more easily apply consistent styling and alignment. But otherwise I think we have a really nice base to demo and handover to research and design teams for final specifications
|
Oh thank you @chrismclarke, I will definitely modify that. And ping you when I push the changes |
…csa-apps into fix/option-tool-icons
| male: 'male' | ||
| }; | ||
| for (const [key, value] of Object.entries(icons)) { | ||
| const iconName = `picsa_options_${key}`; |
There was a problem hiding this comment.
nice idea to add a custom prefix to the icons, will make them easier to identify in the source code
| <div class="genderType" style="color: #800080;" (click)="handleGender('female')" | ||
| [ngStyle]="{'background-color': gender.includes('female') ? 'pink' : 'lightgray'}">Female | ||
| <!-- <img | ||
| *ngIf="femaleIcon" [src]="femaleIcon" /> --> |
There was a problem hiding this comment.
nit(non-blocking)
If the code is no longer needed probably cleaner to just remove, git keeps code history if you ever need to recover. There's a few comments in this file that could probably be deleted
Description
Add a few icons to thee map stepper in the option tool
Discussion
Tracked in issue #103
Preview
https://picsa.app
Screenshots / Videos