Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 645: set tags in resourceNetboxTenantRead #646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sempervictus
Copy link

address #645

@sempervictus
Copy link
Author

These tests are ... "illogical":

=== NAME  TestAccNetboxTenant_tags
    resource_netbox_tenant_test.go:81: Step 1/3 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # netbox_tenant.test_tags will be updated in-place
          ~ resource "netbox_tenant" "test_tags" {
                id          = "69"
                name        = "test-tenant_tags-gjusrf4zcd"
              ~ tags        = [
                  + "test-tenant_tags-gjusrf4zcda",
                ]
                # (2 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccNetboxTenant_tags (1.88s)

is exactly what should be happening because the provider ignored the need to populate its own fields and really the tests should always fail on any data field being null since a read of an empty type would still produce that type, just with no data in it.

@sempervictus sempervictus changed the title set tags in resourceNetboxTenantRead fix 645: set tags in resourceNetboxTenantRead Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant