feat: introduce new api client based on netbox-community/go-netbox #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NetBox API client setup is moved to netbox/client to keep the provider setup code clean. The `Config` struct is passed to the provider functions containing both the legacy- and new API client. The version check in the provider setup is the only API call move to the new client. The only thing changed in the existing resources is the type assertion to access the legacy client.
yoo
commented
May 20, 2024
| trimmed := false | ||
|
|
||
| // This is Go's poor man's while loop | ||
| for strings.HasSuffix(serverURL, "/") { |
There was a problem hiding this comment.
The for loop is not required. TrimRight already removes all instances of /.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the followup PR for #591.
The NetBox API client setup is moved to netbox/client to keep the provider setup code clean. The
Configstruct is passed to the provider functions containing both the legacy- and new API client.The version check in the provider setup is the only API call moved to the new client.
The only thing changed in the existing resources is the type assertion to access the legacy client.