Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom fields in service resource #447

Merged

Conversation

sebastianreloaded
Copy link
Contributor

Adds support for custom fields on ipam service ressource.

I added a test for it, but i'm not sure it is enough:

make testacc
...
=== RUN   TestAccNetboxService_customFields
--- PASS: TestAccNetboxService_customFields (2.68s)
...
PASS
coverage: 73.6% of statements
ok  	command-line-arguments	214.713s	coverage: 73.6% of statements

@fbreckle
Copy link
Collaborator

fbreckle commented Aug 4, 2023

We will probably overhaul custom fields in the near future (see the discussion #443 ), but since this implements the current standard, I do not see why I cannot merge this.

@fbreckle fbreckle merged commit 387e964 into e-breuninger:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants