add boolean and object support

dyw934854565 · Jun 9, 2018 · 0426c79 · 0426c79
1 parent 8c0b347
commit 0426c79
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -8,18 +8,22 @@ add custom attributes to inject tags
 
 ### use
 
+please use it after `html-webpack-plugin`, especially in webpack2+.
+
 add to all inject tags
 ```javascript
     plugins = [
         new htmlWebpackInjectAttributesPlugin({
-            inject: "true"
+            inject: "true",
+            async: true,
+            test: {}
         })  // Object, key should be string, value can be string or function
     ]
 ```
 you got
 
 ```html
-    <script type="text/javascript" src="index.js" inject="true"></script>
+    <script type="text/javascript" src="index.js" inject="true" async test="{}"></script>
 ```
 
 add to chunks in HtmlWebpackPlugin

diff --git a/index.js b/index.js
@@ -10,16 +10,15 @@ function addAttr(compilation, tags, key, val) {
         var value = val;
         if (typeof val === "function") {
             value = val(tag, compilation, index);
+        } else if (typeof val === 'object') {
+            value = JSON.stringify(val);
         }
         tag.attributes[key] = value;
     });
 }
 function alterAssetTags(compilation, htmlPluginData, callback) {
     var options = assign({}, this.options, htmlPluginData.plugin.options && htmlPluginData.plugin.options.attributes);
     forEach(options, function (val, key) {
-        if (typeof val !== 'string' && typeof val !== 'function') {
-            return;
-        }
         addAttr(compilation, htmlPluginData.head, key, val);
         addAttr(compilation, htmlPluginData.body, key, val);
     });
@@ -37,9 +36,19 @@ function htmlWebpackInjectAttributesPlugin(options) {
 
 htmlWebpackInjectAttributesPlugin.prototype.apply = function (compiler) {
     var self = this;
-    compiler.plugin('compilation', function (compilation) {
-        compilation.plugin('html-webpack-plugin-alter-asset-tags', alterAssetTags.bind(self, compilation));
-    });
+
+    if (compiler.hooks) {
+        compiler.hooks.compilation.tap("htmlWebpackInjectAttributesPlugin", function (compilation) {
+            compilation
+                .hooks
+                .htmlWebpackPluginAlterAssetTags
+                .tap("htmlWebpackInjectAttributesPlugin", alterAssetTags.bind(self, compilation));
+        });
+    } else {
+        compiler.plugin('compilation', function (compilation) {
+            compilation.plugin('html-webpack-plugin-alter-asset-tags', alterAssetTags.bind(self, compilation));
+        });
+    }
 };
 
 module.exports = htmlWebpackInjectAttributesPlugin;